Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MLS groups are not usable if I have a proteus client registered to my account but have MLS on current client [WPB-15192] #3197

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Dec 24, 2024

BugWPB-15192 [Android] MLS groups are not usable if I have a proteus client registered to my account but have MLS on current client


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

the current client can be MLS capable but it did not announce it yet to the backend (migration is not forced yet)

Solutions

instead of looking at the user in general to know if interactions are allowed only look at the current client
this will result to the current client ignoring any Proteus self clients when sending but this is an acceptable case

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…to my account but have MLS on current client [WPB-15192]
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Dec 24, 2024
Copy link
Contributor

github-actions bot commented Dec 24, 2024

Test Results

3 349 tests  +5   3 241 ✅ +4   5m 42s ⏱️ ±0s
  572 suites ±0     108 💤 +1 
  572 files   ±0       0 ❌ ±0 

Results for commit cd400d4. ± Comparison against base commit d4e993d.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 54.16%. Comparing base (d4e993d) to head (cd400d4).

Files with missing lines Patch % Lines
...um/logic/feature/conversation/ConversationScope.kt 0.00% 6 Missing ⚠️
.../com/wire/kalium/logic/data/user/UserRepository.kt 0.00% 3 Missing ⚠️
...serveConversationInteractionAvailabilityUseCase.kt 91.66% 1 Missing ⚠️
...ire/kalium/persistence/dao/client/ClientDAOImpl.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3197   +/-   ##
==================================================
  Coverage              54.15%   54.16%           
==================================================
  Files                   1250     1250           
  Lines                  36493    36504   +11     
  Branches                3699     3699           
==================================================
+ Hits                   19763    19771    +8     
- Misses                 15299    15302    +3     
  Partials                1431     1431           
Files with missing lines Coverage Δ
...om/wire/kalium/persistence/dao/client/ClientDAO.kt 100.00% <ø> (ø)
...serveConversationInteractionAvailabilityUseCase.kt 90.90% <91.66%> (+8.30%) ⬆️
...ire/kalium/persistence/dao/client/ClientDAOImpl.kt 78.33% <75.00%> (+3.33%) ⬆️
.../com/wire/kalium/logic/data/user/UserRepository.kt 67.44% <0.00%> (-0.60%) ⬇️
...um/logic/feature/conversation/ConversationScope.kt 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4e993d...cd400d4. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Dec 24, 2024

Datadog Report

Branch report: fix/message-composer-is-blocked-when-the-user-have-1-mls-client-after-migration
Commit report: 2793278
Test service: kalium-jvm

✅ 0 Failed, 3241 Passed, 108 Skipped, 1m 0.3s Total Time

@yamilmedina yamilmedina requested a review from saleniuk December 31, 2024 10:01
@yamilmedina yamilmedina added this pull request to the merge queue Dec 31, 2024
Merged via the queue into release/candidate with commit 7f1da82 Dec 31, 2024
21 checks passed
@yamilmedina yamilmedina deleted the fix/message-composer-is-blocked-when-the-user-have-1-mls-client-after-migration branch December 31, 2024 11:13
github-actions bot pushed a commit that referenced this pull request Dec 31, 2024
…to my account but have MLS on current client [WPB-15192] (#3197)

* fix: MLS groups are not usable if I have a proteus client registered to my account but have MLS on current client [WPB-15192]

* detekt

* detekt

* fix: pr comments

---------

Co-authored-by: yamilmedina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 🚨 Potential breaking changes 👕 size: M type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants