fix: do not commit User and Client upserts if nothing has changed [WPB-15055] 🍒 #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…B-15055] (#3188) * fix: do not commit User and Client upserts if nothing has changed [WPB-15055] * fix unused parameter * fix detekt
github-actions
bot
added
cherry-pick
…-if-nothing-has-changed-cherry-pick
|
Test Results2 935 tests - 443 2 926 ✅ - 345 4m 36s ⏱️ -44s Results for commit f2e310d. ± Comparison against base commit 6ddef73. This pull request removes 3378 and adds 2935 tests. Note that renamed tests count towards both.This pull request removes 107 skipped tests and adds 9 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Bencher Report| Branch | fix/do-not-commit-user-and-client-upserts-if-nothing-has-changed-cherry-pick |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 685.80 |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 338,900.88 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,335,270.62 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 21,836.61 |
saleniuk
deleted the
fix/do-not-commit-user-and-client-upserts-if-nothing-has-changed-cherry-pick
branch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3195 +/- ##
========================================
Coverage 54.11% 54.12%
========================================
Files 1264 1264
Lines 36800 36818 +18
Branches 3735 3743 +8
========================================
+ Hits 19915 19927 +12
- Misses 15446 15449 +3
- Partials 1439 1442 +3
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When the user data is outdated, the app fetches it again and makes an upsert to the database, but even if there are no changes in the data at all, the insert query is still executed and it notifies all other queries unnecessarily.
Solutions
Make it so that when the app upserts User or Client data and there are absolutely no changes, then rollback that query to not make all other queries that depend on that one dirty.
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.