feat: support Proteus federation if MLS not supported by backend (WPB-14250) #3126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes/initiative: federation-and-mls-on-wire-c...
|
yamilmedina
commented
Nov 25, 2024
Comment on lines
+69
to
+80
| private suspend fun isConversationProtocolAbleToFederate(conversationId: ConversationId?): Boolean { | ||
| val isProteusTeam = getDefaultProtocol() == SupportedProtocol.PROTEUS | ||
| val isOtherDomainAllowed: Boolean = conversationId?.let { | ||
| when (val result = getConversationProtocolInfo(it)) { | ||
| is GetConversationProtocolInfoUseCase.Result.Failure -> !isProteusTeam | ||
|
|
||
| is GetConversationProtocolInfoUseCase.Result.Success -> | ||
| !isProteusTeam && result.protocolInfo !is Conversation.ProtocolInfo.Proteus | ||
| } | ||
| } ?: !isProteusTeam | ||
| return isOtherDomainAllowed | ||
| } |
There was a problem hiding this comment.
Note: Logic migrated as-is to preserve retro compatibility with, plus added tests for this here too
Datadog ReportBranch report: ✅ 0 Failed, 3162 Passed, 107 Skipped, 35.52s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3126 +/- ##
==================================================
Coverage 52.64% 52.64%
==================================================
Files 1321 1322 +1
Lines 51615 51645 +30
Branches 4781 4791 +10
==================================================
+ Hits 27172 27191 +19
- Misses 22487 22493 +6
- Partials 1956 1961 +5
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ohassine
approved these changes
Nov 26, 2024
Garzas
approved these changes
Nov 26, 2024
8 tasks
MohamadJaara
deleted the
feat/support-proteus-federation-if-mls-disabled
branch
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
…-14250) (#3126) * chore: use case template * feat: usecase for allowing federated search * feat: add usecase to check for federation search allowance * feat: cleanup * feat: adjust tests to new implementation * feat: adjust tests to new implementation
This was referenced Nov 27, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 29, 2024
…-14250) (#3126) (#3132) * chore: use case template * feat: usecase for allowing federated search * feat: add usecase to check for federation search allowance * feat: cleanup * feat: adjust tests to new implementation * feat: adjust tests to new implementation Co-authored-by: Yamil Medina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
We need to support federation search, according to if MLS is enabled, or if it is configured or not in the backend.
Solutions
Create a new use case centralizing the logic to decide if we need to support federation or not for this: team/conversation/backend.
Before the logic was in the view model in AR, but here is centralized and we can test all the cases for it, therefore now the view model just calls this use case to decide if we need to enable cross domain search.
Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.