Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add LocalNotification SelfDeleteKnock (WPB-3175) #2086

Merged
merged 2 commits into from
Sep 25, 2023
Merged

fix: add LocalNotification SelfDeleteKnock (WPB-3175) #2086

merged 2 commits into from
Sep 25, 2023

Conversation

alexandreferris
Copy link
Contributor

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

This PR only adds LocalNotificationMessage.SelfDeleteKnock and its mapping needed for AR PR : wireapp/wire-android#2269

@alexandreferris alexandreferris self-assigned this Sep 25, 2023
@alexandreferris alexandreferris mentioned this pull request Sep 25, 2023
Merged
4 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023 •
edited
Loading

Unit Test Results

   317 files   - 122     317 suites   - 122   10s ⏱️ - 1m 44s
1 674 tests  - 709  1 643 ✔️  - 637  31 💤  - 72  0 ❌ ±0 

Results for commit 902d630. ± Comparison against base commit 048b06f.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 25, 2023 •
edited
Loading

Datadog Report

All test runs d38e36a 🔗

✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1643 31 10.34s Link
kalium-jvm 0 0 0 2280 103 11m 13s Link

@alexandreferris alexandreferris requested review from a team, yamilmedina, borichellow, vitorhugods, ohassine, saleniuk and Garzas and removed request for a team September 25, 2023 14:28
@alexandreferris alexandreferris added this pull request to the merge queue Sep 25, 2023
Merged via the queue into develop with commit 00d151f Sep 25, 2023
@alexandreferris alexandreferris deleted the fix/self_deleting_ping_sound branch September 25, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garzas Garzas Garzas approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

Assignees

@alexandreferris alexandreferris

Labels
🚨 Potential breaking changes 👕 size: S type: bug / fix 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandreferris @yamilmedina @Garzas