Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trim original PR title #45

Closed
wants to merge 2 commits into from
Closed

Conversation

caldrian
Copy link


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

In the iOS repo the issue has returned that a cherry-pick's PR title has a trailing whitespace character.

Causes (Optional)

Not sure, after the last fix 064d582

Solutions

Try to add another trim() call.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods
Copy link
Member

I've just noticed what was my mistake.

We need to build the TypeScript/JS dist folder after making changes to src. And I noticed that I skipped this last time.

I inherited most of these CI checks from the GitHub TypeScript Action template, and many of the lint checks were annoying and I made the mistake of not fixing all of them.

When I fixed the .trim() thing, I probably ended up ignoring the Check Transpiled JavaScript check, which is the one compares if the dist directory is up-to-date with the src directory...

Anyway, I've fixed it now:

  1. All CI checks are green. Some lints were disabled (even MARKDOWN had lint 🫠).
  2. I've built the dist and re-created the v1.0.2 tag to actually include this change.

Thanks for pointing out this issue and getting your hands dirty to try to fix it.
Prompted me to be a bit cleaner about the mess I shouldn't have left in the first place.

@vitorhugods vitorhugods closed this Dec 3, 2024
@caldrian caldrian deleted the fix/trim-original-pr-title branch December 3, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants