-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unhandled rejection handling #2390
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/** | ||
* rejection-stream.js: TODO: add file header handler. | ||
* | ||
* (C) 2010 Charlie Robbins | ||
* MIT LICENCE | ||
*/ | ||
|
||
'use strict'; | ||
|
||
const { Writable } = require('readable-stream'); | ||
|
||
/** | ||
* TODO: add class description. | ||
* @type {RejectionStream} | ||
* @extends {Writable} | ||
*/ | ||
module.exports = class RejectionStream extends Writable { | ||
/** | ||
* Constructor function for the RejectionStream responsible for wrapping a | ||
* TransportStream; only allowing writes of `info` objects with | ||
* `info.rejection` set to true. | ||
* @param {!TransportStream} transport - Stream to filter to rejections | ||
*/ | ||
constructor(transport) { | ||
super({ objectMode: true }); | ||
|
||
if (!transport) { | ||
throw new Error('RejectionStream requires a TransportStream instance.'); | ||
} | ||
|
||
this.handleRejections = true; | ||
this.transport = transport; | ||
} | ||
|
||
/** | ||
* Writes the info object to our transport instance if (and only if) the | ||
* `rejection` property is set on the info. | ||
* @param {mixed} info - TODO: add param description. | ||
* @param {mixed} enc - TODO: add param description. | ||
* @param {mixed} callback - TODO: add param description. | ||
* @returns {mixed} - TODO: add return description. | ||
* @private | ||
*/ | ||
_write(info, enc, callback) { | ||
if (info.rejection) { | ||
return this.transport.log(info, callback); | ||
} | ||
|
||
callback(); | ||
return true; | ||
} | ||
}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't get used anywhere atm but for completeness it felt like we should have this to parallel
exceptions
right above?