-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulkmode support #55
base: master
Are you sure you want to change the base?
Bulkmode support #55
Conversation
@@ -16,16 +16,20 @@ | |||
"dependencies": { | |||
"request": "2.67.x", | |||
"timespan": "2.3.x", | |||
"json-stringify-safe": "5.0.x" | |||
"json-stringify-safe": "5.0.x", | |||
"nock": "~7.2.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this. It is already in devDependencies
.
@indexzero we have resolved the issues. Could you please check? |
Hey folks. I'm currently relocating from California to New York City so a little underwater with things related to that. Will try to give this a look over in the next few weeks. Sorry for the delay, but you know what they say:
|
hey @indexzero, how did the relocation go? |
Hey @indexzero did you finish your relocation? It's been almost 2 months and we are still waiting for this merge. This is a high priority item since its required to fix this winstonjs/winston-loggly#6. This is causing user's apps to crash, so we'd like to get this merged and published in the next 2 weeks. If you don't have time, do you want Loggly to become a contributor on this project? Otherwise, we might have to fork it and update our links. We'd definitely prefer to keep your repo as you are the original author. Do you have any preference on how to move forward? |
We forked and moved our code here https://github.com/loggly/winston-loggly-bulk. This incorporates the change here. |
@indexzero
We have updated following items in the code