Make serde an optional dependency of zeroconf #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Walker Crouse <[email protected]>
Signed-off-by: Walker Crouse <[email protected]>
Signed-off-by: Walker Crouse <[email protected]>
Signed-off-by: Walker Crouse <[email protected]>
Signed-off-by: Walker Crouse <[email protected]>
Signed-off-by: Walker Crouse <[email protected]>
windy1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
serdean optional dependency.Why
There is no reason to force users to download and compile
serdeif they are not taking advantage of the serialization features; they are not integral to the functionality of this library.Manual Tests
Tested locally with and without serde flag enabled
Documentation Updates
Updated README