Support Windows x86 (cont.) (#57)

* fix: support win x86 * refactor: use `dnssd_sock_t` on apple to simplify the code * update bonjour-sys and version Signed-off-by: Walker Crouse <[email protected]> * add pull_request_template.md Signed-off-by: Walker Crouse <[email protected]> * remove dead code Signed-off-by: Walker Crouse <[email protected]> * use clone_from Signed-off-by: Walker Crouse <[email protected]> * clone -> to_string Signed-off-by: Walker Crouse <[email protected]> * re-add UnwrapMutOrNull for linux Signed-off-by: Walker Crouse <[email protected]> * remove AsCChars from linux; more clone_from replacements Signed-off-by: Walker Crouse <[email protected]> --------- Signed-off-by: Walker Crouse <[email protected]> Co-authored-by: ArcticLampyrid <[email protected]>
windy1 · Jul 26, 2024 · 9dbb42a · 9dbb42a
1 parent ce64b0a
commit 9dbb42a
Show file tree

Hide file tree

Showing 13 changed files with 183 additions and 188 deletions.
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -0,0 +1,13 @@
+## What
+Brief summary of these changes and their impact. The easier it is to follow and understand, the easier to review.
+
+## Why
+Reason for these changes. And why not some other changes (if applicable). Context here can be helpful when later blaming this code/reading logs.
+
+## Manual Tests
+What did you do to verify your changes?
+
+## Documentation Updates
+Did you document the purpose of any new code? Did you add comments explaining anything that might look strange to
+someone trying to figure out what your code is doing a year from now who doesn't know the full context? Is the README
+for this repo still accurate and useful?