Minor internal refactoring to make things a little clearer.

williamtroup · Jan 8, 2024 · cd28ecf · cd28ecf
1 parent 0a872ae
commit cd28ecf
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 17 deletions.
diff --git a/dist/observe.js b/dist/observe.js
@@ -149,7 +149,6 @@
     }
   }
   function compareWatchObjectProperties(oldObject, newObject, watch) {
-    var options = watch.options;
     var propertyName;
     for (propertyName in oldObject) {
       if (oldObject.hasOwnProperty(propertyName)) {
@@ -159,11 +158,11 @@
           propertyNewValue = newObject[propertyName];
         }
         if (isDefinedObject(propertyOldValue) && isDefinedObject(propertyNewValue)) {
-          compareWatchObjectProperties(propertyOldValue, propertyNewValue, options);
+          compareWatchObjectProperties(propertyOldValue, propertyNewValue, watch.options);
         } else {
           if (!isDefinedArray(watch.options.propertyNames) || watch.options.propertyNames.indexOf(propertyName) > -1) {
             if (JSON.stringify(propertyOldValue) !== JSON.stringify(propertyNewValue)) {
-              fireCustomTrigger(options.onPropertyChange, propertyName, propertyOldValue, propertyNewValue);
+              fireCustomTrigger(watch.options.onPropertyChange, propertyName, propertyOldValue, propertyNewValue);
             }
           }
         }

diff --git a/dist/observe.min.js b/dist/observe.min.js
diff --git a/docs/CHANGE_LOG.md b/docs/CHANGE_LOG.md
@@ -1,7 +1,9 @@
 # Observe.js - Change Log:
 
 ## Version 0.6.0:
-- 
+
+#### **General Improvements:**
+- Minor internal refactoring to make things a little clearer.
 
 <br>
 

diff --git a/src/observe.js b/src/observe.js
@@ -236,8 +236,6 @@
     }
 
     function compareWatchObjectProperties( oldObject, newObject, watch ) {
-        var options = watch.options;
-
         for ( var propertyName in oldObject ) {
             if ( oldObject.hasOwnProperty( propertyName ) ) {
                 var propertyOldValue = oldObject[ propertyName ],
@@ -248,12 +246,12 @@
                 }
 
                 if ( isDefinedObject( propertyOldValue ) && isDefinedObject( propertyNewValue ) ) {
-                    compareWatchObjectProperties( propertyOldValue, propertyNewValue, options );
+                    compareWatchObjectProperties( propertyOldValue, propertyNewValue, watch.options );
                 } else {
 
                     if ( !isDefinedArray( watch.options.propertyNames ) || watch.options.propertyNames.indexOf( propertyName ) > -1 ) {
                         if ( JSON.stringify( propertyOldValue ) !== JSON.stringify( propertyNewValue ) ) {
-                            fireCustomTrigger( options.onPropertyChange, propertyName, propertyOldValue, propertyNewValue );
+                            fireCustomTrigger( watch.options.onPropertyChange, propertyName, propertyOldValue, propertyNewValue );
                         }
                     }
                 }