Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFTC-126] suppressed deprecation warning #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

istudens
Copy link
Contributor

@istudens
Copy link
Contributor Author

@chengfang I thought this would be about code change to a newer class of com.arjuna.ats.jbossatx.jta.TransactionManagerDelegate, but it is used there for instance checking only and so it can't be changed.

@chengfang
Copy link
Contributor

com.arjuna.ats.jbossatx.jta.TransactionManagerDelegate has been deprecated with no replacement. So the related check in the code will not be needed now or in the future. If so, that block can be removed, if it's deemed safe to do so.

I think I would keep the deprecation warning for now, until we know it's safe to remove that check.

@istudens
Copy link
Contributor Author

When will we know it is safe to remove it. The class has been deprecated, but it is still there. Hence the check might be needed, right?

@chengfang
Copy link
Contributor

@mmusgrov any idea who are likely still using this deprecated class: com.arjuna.ats.jbossatx.jta.TransactionManagerDelegate?

BTW, I cloned this issue to https://issues.redhat.com/browse/JBTM-3808, since this class is still used in narayana itself. So after its use is removed from narayana itself, we'll have better idea its impact in wildfly-transaction-client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants