jquery: Enable no-extend (allowDeep: true)

Fixes #535
wikimedia · May 2, 2024 · 553add2 · 553add2
1 parent 6c81afc
commit 553add2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/jquery.json b/jquery.json
@@ -14,6 +14,7 @@
 		"no-jquery/no-constructor-attributes": "error",
 		"no-jquery/no-each-util": "error",
 		"no-jquery/no-error": "error",
+		"no-jquery/no-extend": [ "error", { "allowDeep": true } ],
 		"no-jquery/no-fade": "error",
 		"no-jquery/no-global-eval": "error",
 		"no-jquery/no-global-selector": "error",

diff --git a/test/fixtures/jquery/invalid.js b/test/fixtures/jquery/invalid.js
@@ -26,6 +26,11 @@
 	// eslint-disable-next-line no-jquery/no-error
 	$.error( 'err' );
 
+	// eslint-disable-next-line no-jquery/no-extend
+	$.extend( {}, {} );
+	// Deep copy allowed
+	$.extend( true, {}, {} );
+
 	// eslint-disable-next-line no-jquery/no-fade
 	$( [] ).fadeIn();
 

diff --git a/test/fixtures/jquery/valid.js b/test/fixtures/jquery/valid.js
@@ -6,4 +6,7 @@
 	$( [] ).animate( { scrollLeft: 50 } );
 	$( [] ).animate( { scrollTop: 50, scrollLeft: 50 } );
 
+	// Valid: no-jquery/no-extend ignores deep copy
+	$.extend( true, {}, {} );
+
 }() );