ENS #402
Merged
ENS #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serg-plusplus
requested changes
Feb 12, 2024
googolev
force-pushed
the
ens-implementation
branch
from
750e446 to
3805d62
Compare
serg-plusplus
requested changes
Feb 13, 2024
| const WalletAvatar: FC<WalletAvatarProps> = memo(({ seed, className }) => { | ||
| const rootRef = useRef<HTMLDivElement>(null); | ||
|
|
||
| console.log("WALLET AVATAR"); |
Comment on lines
27
to
28
| console.log("fetchEnsName"); | ||
| console.log(seed); |
|
|
||
| return ( | ||
| <div | ||
| ref={rootRef} |
There was a problem hiding this comment.
Why we need this ref?
Comment on lines
51
to
55
| className={classNames( | ||
| "inline-flex items-center justify-center relative", | ||
| "overflow-hidden", | ||
| className, | ||
| )} |
There was a problem hiding this comment.
Why we need this container? We already have inside the AutoIcon and Avatar also can work good without it I guess
Comment on lines
64
to
67
| className={classNames( | ||
| "h-24 w-24 min-w-[6rem] m-0.5", | ||
| "bg-black/40", | ||
| "rounded-l-[.5625rem]", |
There was a problem hiding this comment.
Why we need this classNames here?
There was a problem hiding this comment.
I think It could be better just to pass className from props
| )} | ||
| /> | ||
| <span className="truncate min-w-0"> | ||
| <TReplace msg={ensName ? ensName : wallet.name} /> |
googolev
force-pushed
the
ens-implementation
branch
from
5707849 to
bcdbfe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.