Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tale's icon field whenever imageId changes. Fixes #473 #474

Merged
merged 1 commit into from
May 3, 2021

Conversation

Xarthisius
Copy link
Collaborator

Test case in #473.

@Xarthisius Xarthisius requested a review from craig-willis April 30, 2021 20:17
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #474 (9f81128) into master (bb2d57b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #474   +/-   ##
=======================================
  Coverage   92.11%   92.12%           
=======================================
  Files          52       52           
  Lines        3921     3922    +1     
=======================================
+ Hits         3612     3613    +1     
  Misses        309      309           
Impacted Files Coverage Δ
server/rest/tale.py 95.12% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2d57b...9f81128. Read the comment docs.

Copy link

@craig-willis craig-willis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have I never noticed this? Works for me.

@Xarthisius
Copy link
Collaborator Author

Why have I never noticed this? Works for me.

Judging by the amount of problems I found when I tried to switch base image on an existing Tale (whole-tale/gwvolman#143 whole-tale/gwvolman#142 and this) we haven't been really considering this workflow in our testing.

@Xarthisius Xarthisius merged commit 61d3185 into master May 3, 2021
@Xarthisius Xarthisius deleted the icon_upon_image_change branch May 3, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants