Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding I18n to canvabadges #12

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Adding I18n to canvabadges #12

wants to merge 18 commits into from

Conversation

Kulgar
Copy link
Contributor

@Kulgar Kulgar commented Nov 24, 2014

Hello Whitmer,

Here is the pull request adding i18n mechanisms.

Some notes about it:

  • I did not translate all the pages yet, we first focused on students' pages.
  • Let me know if it is too messy so that I can clean the pull request
  • I tested the application (using specs) and everything seemed fine, but I did not add any specs - I modified some specs because they were failing (because of old syntax)

I don't want this pull request to be to difficult for you to merge in your project, so, let me know if you need me to do anything to help you.

Regis.

@whitmer
Copy link
Owner

whitmer commented Dec 19, 2014

Hi Regis, thanks for doing this. I opted to include only the i18n code and a couple of the translations for now. The full .yml files are merged in, but I'd feel more comfortable applying the translations in a separate step. I'll try to get to this soon-ish, but if you have some time it'd help if you'd do each .erb file as a separate commit so I can more easily see what's going on.

Thanks for spear-heading this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants