-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding I18n to canvabadges #12
base: master
Are you sure you want to change the base?
Conversation
Added 'locale' column to user config and filled it with launch_presentation_locale lti param
Solved some rspec bugs and some deprecations that were failing tests Solved some translation bugs and issues
Hi Regis, thanks for doing this. I opted to include only the i18n code and a couple of the translations for now. The full .yml files are merged in, but I'd feel more comfortable applying the translations in a separate step. I'll try to get to this soon-ish, but if you have some time it'd help if you'd do each .erb file as a separate commit so I can more easily see what's going on. Thanks for spear-heading this! |
Hello Whitmer,
Here is the pull request adding i18n mechanisms.
Some notes about it:
I don't want this pull request to be to difficult for you to merge in your project, so, let me know if you need me to do anything to help you.
Regis.