Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI harness to include and use Ruby 3.4. #501

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

faisal
Copy link
Contributor

@faisal faisal commented Jan 12, 2025

This updates the CI harness to add Ruby 3.4 checks, and run the mdl check in 3.4. It also makes a number of development dependency explicit, since Ruby 3.5 moves those gems out of the standard library.

Check list:

@faisal faisal changed the title Update CI harness include and use Ruby 3.4. WIP: Update CI harness include and use Ruby 3.4. Jan 12, 2025
@faisal
Copy link
Contributor Author

faisal commented Jan 12, 2025

This waits on #502

@faisal
Copy link
Contributor Author

faisal commented Jan 12, 2025

The failure in HEAD is happening in other PRs and seems to be unrelated to this change.

@faisal faisal changed the title WIP: Update CI harness include and use Ruby 3.4. Update CI harness include and use Ruby 3.4. Jan 12, 2025
@faisal
Copy link
Contributor Author

faisal commented Jan 14, 2025

@etagwerker @nunosilva800 do you think it makes sense to merge this one as-is, and worry about Cucumber playing well with the new HEAD after Cucumber 10 finally lands?

@faisal faisal force-pushed the ci_harness_uses_ruby_34 branch from ccbbe87 to 00bd225 Compare January 15, 2025 10:52
@faisal faisal force-pushed the ci_harness_uses_ruby_34 branch from 00bd225 to a9c2dd5 Compare January 15, 2025 10:55
@faisal faisal changed the title Update CI harness include and use Ruby 3.4. Update CI harness to include and use Ruby 3.4. Jan 15, 2025
Copy link
Collaborator

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faisal Looks good to me, thank you!

@etagwerker etagwerker merged commit d4b8900 into whitesmith:main Jan 17, 2025
25 of 26 checks passed
@faisal faisal deleted the ci_harness_uses_ruby_34 branch January 17, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants