Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Bump dependencies #500

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: Bump dependencies #500

wants to merge 1 commit into from

Conversation

faisal
Copy link
Contributor

@faisal faisal commented Dec 24, 2024

This is a WIP PR to bump dependencies to the latest available that pass with all currently-supported Rubies. Currently that's fakefs and mocha, but we could wait and continue to update before landing, if we want. I've tested on macOS with Ruby 3.1 forward.

Note that the CHANGELOG will probably need some reworking before a release. Since we currently have lines for dropping both Ruby 2.7 and 3.0, and lines for dropping two overlapping sets of dependencies.

Check list:

@faisal
Copy link
Contributor Author

faisal commented Dec 24, 2024

Observations on that Cucumber failure:

  1. It's the same "this will be fixed in Cucumber 10" bug that was holding up other recent PRs.
  2. The tests passed locally on 3.4 RC1

Unless somebody wants these changes now, I plan to wait for Cucumber 10 to land and check with that.

@faisal
Copy link
Contributor Author

faisal commented Jan 6, 2025

I suspect we'll want to hold this open until Cucumber 10 lands.

@faisal
Copy link
Contributor Author

faisal commented Jan 10, 2025

I can reproduce that jruby failure locally. Investigating ...

@faisal
Copy link
Contributor Author

faisal commented Jan 12, 2025

This latest push picks up a newer Cucumber, which includes a limited fix for the keywords issue that is causing things to fail on 3.4. I also need to update the CI to include 3.4, and then investigate this new failure on HEAD.

@faisal
Copy link
Contributor Author

faisal commented Jan 12, 2025

This waits on #502.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant