Fix YAML configuration file 'formats' processing #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: Ignores .rubycritic.yml file whitesmith#303 whitesmith#303. Update the documentation to indicate that the key in the .rubycritic.yml configuration file which controls the output format is 'formats' rather than 'format'. Fix a bug in RubyCritic::Cli::Options#to_h which prevents a setting in the YAML configuration file from being used when the setting is an Array (as is the case for the output formats). Modify RubyCritic::CLI::Options::File#formats to return an array of symbols instead of an array of strings, to be consistent with how RubyCritic::CLI::Options::Argv#parse returns the array. Also modify it so it can accept a single output format or a list of formats. The documentation indicates that either is acceptable but the code assumed the input was always an array. Signed-off-by: Christopher Voltz <[email protected]>
etagwerker
approved these changes
Sep 29, 2019
nunosilva800
approved these changes
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Ignores .rubycritic.yml file #303
See #303 for details of the problem and why each of the changes were made.