Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify what happens when “disabled” is added to a link@rel=stylesheet #9870

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sideshowbarker
Copy link
Member

@sideshowbarker sideshowbarker commented Oct 20, 2023

This change reverts commit c63f712 (PR #9798) and moves the requirements for what needs to happen when the disabled attribute is added to the same place in the spec where the requirements for what happens when the disabled attribute is removed are already defined.

The change makes the spec call the existing “remove a CSS style sheet” algorithm in the CSSOM spec.

  • At least two implementers are interested (and none opposed):
    • All UAs support this in principle; none are opposed
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • No new bugs needed in this case
  • MDN issue is filed: …
    • No docs impact

/infrastructure.html ( diff )
/links.html ( diff )
/semantics.html ( diff )

This change reverts commit c63f712
(PR #9798) and moves the requirements for what needs to happen when the
“disabled” attribute is added to the same place in the spec where the
requirements for what happens when the “disabled” attribute is removed
are already defined.

The change makes the spec call the existing “remove a CSS style sheet”
algorithm at https://drafts.csswg.org/cssom/#remove-a-css-style-sheet
source Show resolved Hide resolved
@zcorpan
Copy link
Member

zcorpan commented Mar 19, 2024

See the existing HTMLLinkElement-disabled-* tests in https://wpt.fyi/results/css/cssom

None of these use setAttribute('disabled', '') as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants