-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: make shape attributes table consistent #9851
Editorial: make shape attributes table consistent #9851
Conversation
e85037c
to
1334934
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also not ideal as-is I think. Non-conforming is a state that for this particular attribute is relevant for https://html.spec.whatwg.org/#canonical-keyword as multiple keywords map to the same state. And non-conforming is not the same as a brief description.
We could restate the non-conforming keywords after the table, but perhaps having an additional column for them is better. Some kind of "Non-conforming" column with checkmarks. Or perhaps the inverse if folks think that's not clear enough.
As I mentioned in #9832 (comment), I think we should keep the notes column, in addition to adding the brief description column. |
56d6413
to
ce3bb26
Compare
Okay I've kept the Let me know your thoughts and I'll update #9850 to do the same. |
@domenic how about we instead move the "non-conforming" annotations into the keyword column? As
? (And then drop the paragraph that states they are non-conforming as it's redundant with the table.) |
From those two tables I think the first is better a11y-wise. I'd be a bit worried that if you land on one of the non-conforming cells in isolation you can't make sense of it, unless perhaps we'd also mark the keywords as headings? (Amazing by the way how it's inconsistent with regards to whether the abbreviated keyword is conforming or not.) |
We could always overkill it with CSS grid inside the table cell, at the cost of some extra markup and having to edit the stylesheet... |
In Chat we have settled on the extra Conforming column. Notes: |
ce3bb26
to
b5c2171
Compare
I've added the classes but the styles aren't applying as Aside from that I think this is complete. |
Yeah, PR preview doesn't seem to work that well in certain ways. One of us can do a local build and double-check before merging (probably during the workweek). |
b5c2171
to
3ddfa50
Compare
This formats the wording & HTML around
shape
attribute such that it is consistent with the format described in #9832/image-maps.html ( diff )