make CORS settings attributes consistent #9834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
added
the
editorial
annevk
reviewed
Oct 5, 2023
There was a problem hiding this comment.
Thanks!
You also need "Keywords" -> "Keyword" in the table heading and flip the order of the first two table columns. As in, "Keyword" first, then "State".
I'm having second thoughts on requiring closing tags for tables as @domenic suggested "offline" we don't need them and I don't particularly care for them. Since you didn't add them for a bunch of elements in the table, maybe leave those changes out altogether for now?
keithamus
force-pushed
the
make-cors-settings-attributes-consistent
branch
2 times, most recently
from
97b7195 to
97f045f
Compare
annevk
approved these changes
Oct 5, 2023
annevk
requested changes
Oct 5, 2023
keithamus
force-pushed
the
make-cors-settings-attributes-consistent
branch
from
97f045f to
64ee40a
Compare
annevk
approved these changes
Oct 5, 2023
domenic
reviewed
Oct 7, 2023
| <p>A <dfn>CORS settings attribute</dfn> is an <span>enumerated attribute</span>. The following | ||
| table lists the keywords and states for the attribute — the states given in the first cell | ||
| of the rows with keywords give the states to which those keywords map.</p> | ||
| <p>A <dfn>CORS settings attribute</dfn> The attribute is an <span>enumerated attribute</span> with |
There was a problem hiding this comment.
This seems like a typo? The attribute is extra.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #9832
This formats the wording & HTML acround
CORS - setttings attributesuch that it is consistent with the format described in #9832(See WHATWG Working Mode: Changes for more details.)
/urls-and-fetching.html ( diff )