-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagereveal
event
#9818
Add pagereveal
event
#9818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@smaug---- @domenic I think this is ready for review, I checked the appropriate boxes. |
@domenic I think this is ready for another run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Found a few new nits, and several old ones did not get resolved, including:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the missed comments, apparently some comments appear in the review pane and not in the comments pane...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I did push one more commit to move the event interface back into event interfaces.
Since Gecko has been quite involved in reviewing this, and hasn't yet given a clear "LGTM", I'll give folks like @smaug---- and @zcorpan another day or two to weigh in before we merge. But I agree with your current assessment that there seems to be Gecko support, so unless I hear otherwise I'll default to merging soon.
Add
pagereveal
event, and thePageRevealEvent
interface.The
pagereveal
event is fired at the beginning of the first rendering opportunity after activation (initial load or reactivation).It is a way for the author to execute some JS that affects the presentation "just in time" for the first frame.
If there is an inbound cross-document view transition, the reveal event holds a reference to the
ViewTransition
object.Closes #9315.
pagereveal
event mdn/mdn#467(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/index.html ( diff )
/indices.html ( diff )
/infrastructure.html ( diff )
/nav-history-apis.html ( diff )
/webappapis.html ( diff )