Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename HTMLOrSVGElement to HTMLOrForeignElement #4893

Closed

Conversation

ExE-Boss
Copy link

@ExE-Boss ExE-Boss commented Sep 8, 2019

Part of #4702

(See WHATWG Working Mode: Changes for more details.)

Closes #5248


/dom.html ( diff )
/urls-and-fetching.html ( diff )

@ExE-Boss ExE-Boss force-pushed the rename/html-or-foreign-element branch from a7b9f0a to 9028064 Compare September 8, 2019 19:00
@ExE-Boss ExE-Boss force-pushed the rename/html-or-foreign-element branch from 9028064 to 194fffc Compare September 8, 2019 19:02
@domenic
Copy link
Member

domenic commented Sep 8, 2019

This does not contain the normative changes as was indicated in #4702.

Are the corresponding changes to the MathML spec landed yet? (It should first reference HTMLOrSVGElement, with an outstanding pull request to change it to HTMLOrForeignElement.)

Do those changes meet the WHATWG working mode criteria, i.e. are multiple implementers planning on landing dataset, nonce, autofocus, tabIndex, focus(), and blur() on MathML elements? (Note: given that Chromium does not implement MathML, this must require both Gecko and WebKit to be landing such changes.)

Are there tests showing the functionality of all of those pieces on MathML elements?

A renaming pull request is the very last piece that will land in the specification ecosystem, since it has no normative impact. First we must achieve the normative results indicated above.

@domenic domenic added the do not merge yet Pull request must not be merged per rationale in comment label Sep 8, 2019
@fred-wang
Copy link
Contributor

cc @bkardell

This does not contain the normative changes as was indicated in #4702.

Are the corresponding changes to the MathML spec landed yet? (It should first reference HTMLOrSVGElement, with an outstanding pull request to change it to HTMLOrForeignElement.)

MathML Core uses HTMLOrForeignElement with a link to HTMLOrSVGElement: https://mathml-refresh.github.io/mathml-core/#dom-and-javascript

If you really want a PR to change the link to HTMLOrForeignElement it's straightforward to open one.

Do those changes meet the WHATWG working mode criteria, i.e. are multiple implementers planning on landing dataset, nonce, autofocus, tabIndex, focus(), and blur() on MathML elements? (Note: given that Chromium does not implement MathML, this must require both Gecko and WebKit to be landing such changes.)

Gecko and WebKit implement the HTMLOrForeignElement interface for MathML elements and the same is true for Chromium when experimental web platform features are enabled.

Are there tests showing the functionality of all of those pieces on MathML elements?

Yes they are.

A renaming pull request is the very last piece that will land in the specification ecosystem, since it has no normative impact. First we must achieve the normative results indicated above.

Is there anything else blocking this change?

@domenic
Copy link
Member

domenic commented Jan 21, 2020

If you really want a PR to change the link to HTMLOrForeignElement it's straightforward to open one.

Yes, it'd be good to have such a PR.

Gecko and WebKit implement the HTMLOrForeignElement interface for MathML elements and the same is true for Chromium when experimental web platform features are enabled.

Are the former two intending to ship to stable? (I know for Chromium the Intent to Ship has not been sent, much less approved.)

Yes they are.

Can you link to them?

@domenic
Copy link
Member

domenic commented Jan 21, 2020

I forgot:

Is there anything else blocking this change?

The contributor for this pull request is not currently able to contribute to WHATWG standards, due to their use of a pseudonym. They need to update their data at https://github.com/whatwg/participant-data/blob/master/individuals.json before we can verify them and accept contributions. (See whatwg/sg#93 for more.)

@fred-wang
Copy link
Contributor

If you really want a PR to change the link to HTMLOrForeignElement it's straightforward to open one.
Yes, it'd be good to have such a PR.

Done: w3c/mathml-core#19

Are the former two intending to ship to stable? (I know for Chromium the Intent to Ship has not been sent, much less approved.)

It has been shipped in Firefox release since last year: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/71#MathML

It's also in Safari Tech Preview but because of https://trac.webkit.org/wiki/FAQ#Releases I'd rather let @rniwa or someone else from Apple comment, if they are willing to.

Regarding Chromium, I'm not sure I understand how I should read your comment... It sounds you are quite pessimistic but maybe that's just a text communication issue.

Can you link to them?

Here are the tests from the Gecko patch to add MathMLElement:

https://w3c-test.org/mathml/relations/html5-tree/clipboard-event-handlers.tentative.html
https://w3c-test.org/mathml/relations/html5-tree/css-inline-style-dynamic.tentative.html
https://w3c-test.org/mathml/relations/html5-tree/css-inline-style-interface.tentative.html
https://w3c-test.org/mathml/relations/html5-tree/html-or-foreign-element-interfaces.tentative.html
https://w3c-test.org/mathml/relations/html5-tree/math-global-event-handlers.tentative.html
https://w3c-test.org/mathml/relations/html5-tree/tabindex-001.html
https://w3c-test.org/mathml/relations/html5-tree/tabindex-002.html

I can't find tests for nonce or autofocus ; @bkardell do you remember why they are not tested ?

@fred-wang
Copy link
Contributor

The contributor for this pull request is not currently able to contribute to WHATWG standards, due to their use of a pseudonym. They need to update their data at https://github.com/whatwg/participant-data/blob/master/individuals.json before we can verify them and accept contributions. (See whatwg/sg#93 for more.)

@ExE-Boss Thank you very much for working on this PR and for your persistent effort on this change at the WHATWG. Can you please rebase your PR? Are you comfortable with @domenic 's request? If not, Igalia will be happy to take over this.

@ExE-Boss
Copy link
Author

ExE-Boss commented Jan 23, 2020

I’m not comfortable with putting my real identity into any VCS repository.

@bkardell
Copy link
Contributor

@domenic @annevk can either of you advise what we should do here? should igalia send a different PR, or can we transfer this one to us somehow or...?

@domenic
Copy link
Member

domenic commented Jan 24, 2020

A different PR makes sense. Be sure to fill out the template.

@ExE-Boss
Copy link
Author

ExE-Boss commented Feb 19, 2020

Closing in favour of #5248.

@ExE-Boss ExE-Boss closed this Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet Pull request must not be merged per rationale in comment
Development

Successfully merging this pull request may close these issues.

4 participants