-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rename HTMLOrSVGElement
to HTMLOrForeignElement
#4893
Conversation
a7b9f0a
to
9028064
Compare
9028064
to
194fffc
Compare
This does not contain the normative changes as was indicated in #4702. Are the corresponding changes to the MathML spec landed yet? (It should first reference HTMLOrSVGElement, with an outstanding pull request to change it to HTMLOrForeignElement.) Do those changes meet the WHATWG working mode criteria, i.e. are multiple implementers planning on landing dataset, nonce, autofocus, tabIndex, focus(), and blur() on MathML elements? (Note: given that Chromium does not implement MathML, this must require both Gecko and WebKit to be landing such changes.) Are there tests showing the functionality of all of those pieces on MathML elements? A renaming pull request is the very last piece that will land in the specification ecosystem, since it has no normative impact. First we must achieve the normative results indicated above. |
cc @bkardell
MathML Core uses HTMLOrForeignElement with a link to HTMLOrSVGElement: https://mathml-refresh.github.io/mathml-core/#dom-and-javascript If you really want a PR to change the link to HTMLOrForeignElement it's straightforward to open one.
Gecko and WebKit implement the
Yes they are.
Is there anything else blocking this change? |
Yes, it'd be good to have such a PR.
Are the former two intending to ship to stable? (I know for Chromium the Intent to Ship has not been sent, much less approved.)
Can you link to them? |
I forgot:
The contributor for this pull request is not currently able to contribute to WHATWG standards, due to their use of a pseudonym. They need to update their data at https://github.com/whatwg/participant-data/blob/master/individuals.json before we can verify them and accept contributions. (See whatwg/sg#93 for more.) |
Done: w3c/mathml-core#19
It has been shipped in Firefox release since last year: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/71#MathML It's also in Safari Tech Preview but because of https://trac.webkit.org/wiki/FAQ#Releases I'd rather let @rniwa or someone else from Apple comment, if they are willing to. Regarding Chromium, I'm not sure I understand how I should read your comment... It sounds you are quite pessimistic but maybe that's just a text communication issue.
Here are the tests from the Gecko patch to add MathMLElement: https://w3c-test.org/mathml/relations/html5-tree/clipboard-event-handlers.tentative.html I can't find tests for nonce or autofocus ; @bkardell do you remember why they are not tested ? |
@ExE-Boss Thank you very much for working on this PR and for your persistent effort on this change at the WHATWG. Can you please rebase your PR? Are you comfortable with @domenic 's request? If not, Igalia will be happy to take over this. |
I’m not comfortable with putting my real identity into any VCS repository. |
A different PR makes sense. Be sure to fill out the template. |
Closing in favour of #5248. |
Part of #4702
(See WHATWG Working Mode: Changes for more details.)
Closes #5248
/dom.html ( diff )
/urls-and-fetching.html ( diff )