Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that <details> toggle events happen during parsing #4574

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

domenic
Copy link
Member

@domenic domenic commented Apr 26, 2019

Closes #4500.

(See WHATWG Working Mode: Changes for more details.)


/interactive-elements.html ( diff )

@domenic domenic added the clarification Standard could be clearer label Apr 26, 2019
@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label Apr 30, 2019
@annevk
Copy link
Member

annevk commented Apr 30, 2019

Adding do not merge yet as I cannot reproduce this in XMLHttpRequest.

Base automatically changed from master to main January 15, 2021 07:57
@domenic domenic force-pushed the details-toggle-from-parser branch from 87ba779 to 7f3966b Compare November 1, 2023 06:19
@domenic
Copy link
Member Author

domenic commented Nov 1, 2023

I've rebased this and web-platform-tests/wpt#16244 and they should be ready to merge.

Adding do not merge yet as I cannot reproduce this in XMLHttpRequest.

XMLHttpRequest documents are parsed before anyone has a chance to attach event listeners to them, and do not run inline <script>s. So I do not think this is relevant.

@domenic domenic force-pushed the details-toggle-from-parser branch from 7f3966b to 8ff99f8 Compare November 1, 2023 06:38
@domenic domenic removed the do not merge yet Pull request must not be merged per rationale in comment label Nov 1, 2023
@domenic domenic requested a review from annevk November 1, 2023 06:38
@domenic domenic merged commit 00a01ba into main Nov 2, 2023
1 check passed
@domenic domenic deleted the details-toggle-from-parser branch November 2, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer
Development

Successfully merging this pull request may close these issues.

Clarify that <details open> fires the toggle event even if the open attribute is set from the parser
2 participants