Use DOM's post-connection steps for <iframe>
elements
#10840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In whatwg/dom#1261, the concept of DOM post-connection steps were introduced, as a checkpoint to run scripts and create browsing contexts synchronously during insertion, but after all DOM mutations are complete. After that, #10188 landed to make use of the post-connection steps for
<script>
elements, but no such PR was made for<iframe>
elements, despite 2/3 browser engines implementing iframe insertion with post-connection steps, and no strong objections from the third (Gecko). This PR updates the iframe processing model to create its nested navigable/browsing context during the element's post-connection steps, instead of the normal insertion steps. Fixes #10828.@smaug---- Are you on board with this? Is it fair to say there are no strong objections for using this timing for
<iframe>
elements, as Chromium and WebKit do?/iframe-embed-object.html ( diff )