New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixups to Merge Existing and New Import Maps #10837

Merged

domenic merged 1 commit into whatwg:main from yoavweiss:fixup_merge_existing_and_new

Dec 9, 2024

Contributor

yoavweiss commented Dec 9, 2024 •

edited by pr-preview bot

Loading

This fixes #10833, by addressing the two editorial issue pointed out there:

Defines oldImportMap as the global's import map.
Removes specifierKey from scopeImports, rather than specifier.

I believe the below checks do not apply, as this is an editorial change.

At least two implementers are interested (and none opposed):
- …
- …
Tests are written and can be reviewed and commented upon at:
- …
Implementation bugs are filed:
- Chromium: …
- Gecko: …
- WebKit: …
- Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
- Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
Corresponding HTML AAM & ARIA in HTML issues & PRs:
MDN issue is filed: …
The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

/webappapis.html ( diff )


          Fixups to Merge Existing and New Import Maps

3b4fefa

yoavweiss requested a review from domenic

December 9, 2024 05:22

domenic approved these changes

View reviewed changes

Member

domenic left a comment

Thanks!

domenic merged commit b8e8f6d into whatwg:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet