-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace existing usage of blob URL entry's object #10792
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
annevk
reviewed
Nov 25, 2024
annevk
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This algorithm really needs a rewrite, but that's not your job. This looks good enough to me, thanks! @domenic @whatwg/media any final thoughts?
domenic
approved these changes
Dec 7, 2024
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Dec 18, 2024
Changes from whatwg/html#10792 No code changes, only comments.
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Dec 18, 2024
Changes from whatwg/html#10792 No code changes, only comments.
AtkinsSJ
added a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Dec 18, 2024
Changes from whatwg/html#10792 No code changes, only comments.
pbrw
pushed a commit
to pbrw/ladybird
that referenced
this pull request
Jan 14, 2025
Changes from whatwg/html#10792 No code changes, only comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in whatwg/fetch#1783 (comment), this change updates an existing use of blob URL entry's object so that the proposed "obtain a blob object" algorithm is used instead. This algorithm is being added in https://github.com/w3c/FileAPI/pull/201/files.
/infrastructure.html ( diff )
/media.html ( diff )