Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace existing usage of blob URL entry's object #10792

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Conversation

recvfrom
Copy link
Contributor

@recvfrom recvfrom commented Nov 25, 2024

As suggested in whatwg/fetch#1783 (comment), this change updates an existing use of blob URL entry's object so that the proposed "obtain a blob object" algorithm is used instead. This algorithm is being added in https://github.com/w3c/FileAPI/pull/201/files.


/infrastructure.html ( diff )
/media.html ( diff )

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
@recvfrom recvfrom marked this pull request as ready for review December 5, 2024 01:56
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This algorithm really needs a rewrite, but that's not your job. This looks good enough to me, thanks! @domenic @whatwg/media any final thoughts?

@annevk annevk merged commit ec53481 into whatwg:main Dec 9, 2024
2 checks passed
AtkinsSJ added a commit to AtkinsSJ/ladybird that referenced this pull request Dec 18, 2024
AtkinsSJ added a commit to AtkinsSJ/ladybird that referenced this pull request Dec 18, 2024
AtkinsSJ added a commit to LadybirdBrowser/ladybird that referenced this pull request Dec 18, 2024
pbrw pushed a commit to pbrw/ladybird that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants