Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely solely on transient activation for orientation events #209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Nov 10, 2022

Please see:
whatwg/html#8490

  • At least two implementers are interested (and none opposed):
    • Chrome implements this behavior (in that they special case screen orientation change events to call .requestFullscreen()).
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
  • MDN issue is filed: …

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Nov 28, 2022

@foolip, the "triggered by a user generated orientation change" was underspecified and only implemented in Chrome. We are trying to address this issue in an interoperable manner in whatwg/html#8490

However, Screen Orientation no longer defines "triggered by a user generated orientation change" so that doesn't make sense anymore in the FS spec (i.e., it doesn't link to anything anymore).

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Nov 28, 2022

To be clear, there is interest to align WebKit with Chromium's behavior... but we need to specify this properly in HTML and then hook full screen API properly once that's done (independently of this PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant