Refactor/gabang2/code refactoring #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarmaPol
approved these changes
Oct 6, 2023
| @@ -9,7 +9,7 @@ | |||
| import java.util.Optional; | |||
|
|
|||
| public interface FeedRepository extends JpaRepository<Feed, Long> { | |||
| List<Feed> findFeedByMemberAndDelYn(Member member, Boolean delYn); | |||
| List<Feed> findFeedByMemberAndDelYnAndFulfillYn(Member member, Boolean delYn, Boolean fulfillYn); | |||
|
|
|||
There was a problem hiding this comment.
FulfillYn도 고려해야하네요
수정해주셔서 감사합니다
| * Level 변경시 모든 멤버의 레벨에 반영 | ||
| */ | ||
| private void allMemberLevelChange(){ | ||
| memberRepository.findAll().forEach(member -> member.setLevel(getMemberLevel(member.getExp()))); |
KarmaPol
reviewed
Oct 6, 2023
| @@ -29,6 +29,8 @@ public class ImageService { | |||
|
|
|||
| public String updateImage(MultipartFile file, String entityName, String columnName) { | |||
|
|
|||
| if (file.isEmpty()) return null; | |||
There was a problem hiding this comment.
파일 유효성 체크를 이미지서비스에 빼셨네요
중복 많이 줄인 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌲 Summary
level&member코드 클린코드로 변경... 하도록 노력했습니다.
☘️ Issue number and link
#65
🌵 To Reviewers
보고 리뷰 꼭 부탁드릴게요 !