Change to allow the use of a customed linemod version #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING! This PR shoudn't be merged now because this would need parallel modification on ecto_linemod.
@vrabaud I found a way to use different image sizes for linemod, kinectV2 sizes for me (512x424, 960x540, 1920x1080).
We need to not use
getDefaultLINEMODbecauseT_DEFAULTSis usually{5,8}and QHD image size for example can't be divided by 8.https://github.com/Itseez/opencv_contrib/blob/master/modules/rgbd/src/linemod.cpp#L1825-L1840
Also like @nlyubova said the configuration file for training needs to specify the renderer window size to be the one of the kinectV2 size.
I am suggesting here that we just add new params to the config file to allow the use of a "customed linemod"
Problem was discussed on #28
Let me know what you think about this.