Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page feedback: moving ajaxed-in PFT file to /assets #2232

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

Garneauma
Copy link
Contributor

Related to WET-407

@Garneauma Garneauma temporarily deployed to github-ci August 21, 2023 12:26 — with GitHub Actions Inactive
@duboisp
Copy link
Member

duboisp commented Aug 21, 2023

Pre-approved upon local testing + code review.

This is going to be a Patch change because that feedback pattern is provisional

_config.yml Outdated Show resolved Hide resolved
@Garneauma Garneauma temporarily deployed to github-ci August 22, 2023 13:10 — with GitHub Actions Inactive
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was reviewed and fully tested. With the requested change, it's going to work in the gh-page environment.

This is patch change considering that change-set is provisional and this is only an update to it.

@duboisp duboisp merged commit 180e0ae into wet-boew:master Aug 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants