-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gc institution #2228
Feature/gc institution #2228
Conversation
@jmealing Could you please move this documentation in the newly created section /design-patterns ? Thank you. |
cb0891b
to
988216a
Compare
@Garneauma moved |
@Garneauma I'm going to work on the FR page now that EN seems to be all correct and reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few change required
- Document as design pattern, where there is no versioning information.
- Remove the grid with only 1 column and leverage the limited width content instead.
- Extend the limited with content to also behave on list that leverage colcount-2 style
b0534bd
to
c2028c1
Compare
c2028c1
to
d7f13f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review and tested, everything do work as expected. There is just one little change which is to move the alert fragment into a different folder. After that, this PR will be ready.
The only thing to fix are going to fix the potential merge conflict regarding the documentation_pattern.html file because the same file is present in the gc-intro design pattern PR.
design-patterns/gc-institution/samples/gc-institution-alert.html
Outdated
Show resolved
Hide resolved
d7f13f8
to
4b80f9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, please remove the include
_includes/design-patterns/gc-institution/gc-institution-alert.html
Outdated
Show resolved
Hide resolved
4b80f9e
to
3ca5578
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested locally, everything work as expected.
Great work on this.
We will wait for the completion of all the request in https://github.com/orgs/wet-boew/projects/4/views/1 + approval from DTO and PP before to merge it. |
Rectification: This is a MINOR change. |
Create component for About the institution
To do:
[✓ ] French
[ ✓] update well-bold class to bold class (well-bold feature is modified in another PR)
#2237
[ ] DTO guidance/content
DTO Design system PRs:
EN: canada-ca/design-system#327
FR: canada-ca/systeme-conception#217