Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gc institution #2228

Merged
merged 18 commits into from
Apr 15, 2024
Merged

Conversation

jmealing
Copy link
Contributor

@jmealing jmealing commented Aug 16, 2023

Create component for About the institution

To do:
[✓ ] French
[ ✓] update well-bold class to bold class (well-bold feature is modified in another PR)
#2237
[ ] DTO guidance/content

DTO Design system PRs:
EN: canada-ca/design-system#327
FR: canada-ca/systeme-conception#217

components/gc-institution/gc-institution-en.html Outdated Show resolved Hide resolved
components/gc-institution/gc-institution-en.html Outdated Show resolved Hide resolved
components/gc-institution/gc-institution-en.html Outdated Show resolved Hide resolved
components/gc-institution/gc-institution-en.html Outdated Show resolved Hide resolved
components/gc-institution/gc-institution-en.html Outdated Show resolved Hide resolved
@jmealing jmealing temporarily deployed to github-ci September 11, 2023 14:24 — with GitHub Actions Inactive
@Garneauma
Copy link
Contributor

@jmealing Could you please move this documentation in the newly created section /design-patterns ? Thank you.

@jmealing
Copy link
Contributor Author

jmealing commented Dec 5, 2023

@Garneauma moved

design-patterns/gc-institution/gc-institution-en.html Outdated Show resolved Hide resolved
design-patterns/gc-institution/gc-institution-en.html Outdated Show resolved Hide resolved
design-patterns/gc-institution/index.json-ld Outdated Show resolved Hide resolved
design-patterns/gc-institution/index.json-ld Outdated Show resolved Hide resolved
design-patterns/gc-institution/gc-institution-en.html Outdated Show resolved Hide resolved
design-patterns/gc-institution/gc-institution-en.html Outdated Show resolved Hide resolved
@jmealing
Copy link
Contributor Author

@Garneauma I'm going to work on the FR page now that EN seems to be all correct and reviewed

@Garneauma Garneauma assigned duboisp and unassigned jmealing Mar 11, 2024
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few change required

  • Document as design pattern, where there is no versioning information.
  • Remove the grid with only 1 column and leverage the limited width content instead.
  • Extend the limited with content to also behave on list that leverage colcount-2 style

design-patterns/gc-institution/index.json-ld Outdated Show resolved Hide resolved
design-patterns/gc-institution/gc-institution-fr.html Outdated Show resolved Hide resolved
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and tested, everything do work as expected. There is just one little change which is to move the alert fragment into a different folder. After that, this PR will be ready.

The only thing to fix are going to fix the potential merge conflict regarding the documentation_pattern.html file because the same file is present in the gc-intro design pattern PR.

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, please remove the include

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested locally, everything work as expected.

Great work on this.

@duboisp
Copy link
Member

duboisp commented Mar 21, 2024

We will wait for the completion of all the request in https://github.com/orgs/wet-boew/projects/4/views/1 + approval from DTO and PP before to merge it.

@duboisp duboisp removed their assignment Mar 21, 2024
@Garneauma Garneauma assigned duboisp and unassigned duboisp Mar 27, 2024
@Garneauma Garneauma merged commit ce47c9e into wet-boew:master Apr 15, 2024
1 check passed
@Garneauma
Copy link
Contributor

Rectification: This is a MINOR change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Query: Project item Part of a github project
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

4 participants