Update and-or.css #2219
Merged
Update and-or.css #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated CSS to allow brdr-0 to exist on all resolutions when the design is stacked, and not just "always stacked".
|
Pre-approved upon review and after confirming there is an example of this change. |
|
pre-approved upon testing Relates to |
|
@duboisp there is an example of the update on index.html under the updated header of no border. |
Updated examples to show that brdr-0 can now be added to any side by side version and the border left will disappear when stacked.
duboisp
previously approved these changes
Aug 15, 2023
duboisp
requested changes
Aug 15, 2023
There was a problem hiding this comment.
Fix the HTML markup in the edge-cases.html. The <s> element can only be use in phrasing context according to HTML 5 spec.
Other than that, the rest is good to be squash and merge
SebastianBurke
pushed a commit
to SebastianBurke/GCWeb
that referenced
this pull request
Mar 6, 2024
…ew#2219) * Update and-or.css Updated CSS to allow brdr-0 to exist on all resolutions when the design is stacked, and not just "always stacked". * Update index.html Updated examples to show that brdr-0 can now be added to any side by side version and the border left will disappear when stacked. * Update edge-cases.html * méli-mélo 2021-05-conjunction - Content adjustment according to HTML5 parsing Patch - Méli-mélo 2021-05-conjunction --------- Co-authored-by: Pierre Dubois <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated CSS to allow brdr-0 to exist on all resolutions when the design is stacked, and not just "always stacked".