-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gc-featured-link: adding bg color option #2214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This is broken in basic HTML mode, we should still display the featured banner. In basic mode I can see a white text with a white background.
- How do we ensure the text inside the banner do have and maintain a sufficient contrast ratio? Should we auto switch the text color between black and white depending of the luminosity of the background color that was set?
Adjusted to only add the white background on standard version.
If you look at the example, there is the following alert: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the way it is setup and do self-adjust to ensure it meet the contrast ratio.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testé localement et ça fonctionne tel que prévu, il va rester à adjuster la couleur du texte par défaut juste avant que l'initialization soit complété.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approved upon the default loading style in standard mode do have sufficient contrast ratio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and reviewed. Every work as expected.
Adding option to customize the background colour of featured links.
Added CSS to hide the customized link by default to prevent a colour flick on load.