-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step by step navigation: adding documentation #2181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like to create a include for this component and to update the "advanced service" template to use that include?
And I can see there is new CSS added for this component, is that necessary or probably a minor/patch change to the component?
d223ed9
to
8fc2540
Compare
8fc2540
to
f8660f5
Compare
Pre-approved upon review and local testing. To be confirm: The CSS code for the download link might need to be removed as it was already moved I think. |
f8660f5
to
40cb70f
Compare
40cb70f
to
ad1a229
Compare
Removed the .gc-dwnld CSS. It was added by mistake during merge conflict resolution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review and tested locally,
Work as expected.
This is a minor change because it add another supported pattern for the gc step step which is the same as the version 1 but simpler to code for an author.
Adding .gc-stp-stp documentation and example.