Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step by step navigation: adding documentation #2181

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

Garneauma
Copy link
Contributor

Adding .gc-stp-stp documentation and example.

@Garneauma Garneauma temporarily deployed to github-ci June 30, 2023 14:30 — with GitHub Actions Inactive
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to create a include for this component and to update the "advanced service" template to use that include?

And I can see there is new CSS added for this component, is that necessary or probably a minor/patch change to the component?

components/gc-stp-stp/_base.scss Outdated Show resolved Hide resolved
components/gc-stp-stp/gc-stp-stp-en.html Outdated Show resolved Hide resolved
@duboisp
Copy link
Member

duboisp commented Sep 11, 2023

Pre-approved upon review and local testing.

To be confirm: The CSS code for the download link might need to be removed as it was already moved I think.

@Garneauma Garneauma temporarily deployed to github-ci September 12, 2023 12:34 — with GitHub Actions Inactive
@Garneauma
Copy link
Contributor Author

Removed the .gc-dwnld CSS. It was added by mistake during merge conflict resolution.

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and tested locally,

Work as expected.

This is a minor change because it add another supported pattern for the gc step step which is the same as the version 1 but simpler to code for an author.

@duboisp duboisp merged commit 63861c8 into wet-boew:master Sep 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants