Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCAG upgrade -- add WCAG assessment for alert component #2145

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

shiva-sc
Copy link
Contributor

@shiva-sc shiva-sc commented Apr 13, 2023

Related to reference number: wet-326

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to convert this JSON file according to the new structure for the ACR methodology.

The conversion will be similar to what we did in this PR: #2070 where you can have an overview of the change required here: 31f9021#diff-1a027235a81ef8eeea87a992133cb1b51d6990664aa12d981b02a1e81a130408.

Please create the EN and FR page to generate the HTML page for this report.

The HTML version of this report would need to be referenced in the index.json-ld in the examples under the "reports" category.

Todo:

  • Convert the JSON report according to ACR methodology reporting format
  • Create EN and FR placeholder report file
  • Add link to the EN and FR report from the index.json-ld file

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the requested change is completed, we should be good to merge this one.

Todo:

  • Fix all JSON parsing issue
  • Include the automated tool JSON result with the report.

common/alert/reports/a11y-1.json Outdated Show resolved Hide resolved
common/alert/reports/a11y-1.json Outdated Show resolved Hide resolved
common/alert/reports/a11y-1.json Outdated Show resolved Hide resolved
common/alert/reports/a11y-1.json Outdated Show resolved Hide resolved
common/alert/reports/a11y-1.json Outdated Show resolved Hide resolved
common/alert/reports/a11y-1.json Outdated Show resolved Hide resolved
common/alert/reports/a11y-1.json Outdated Show resolved Hide resolved
common/alert/reports/a11y-1.json Outdated Show resolved Hide resolved
common/alert/reports/a11y-1.json Outdated Show resolved Hide resolved
common/alert/reports/a11y-1.json Outdated Show resolved Hide resolved
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A broken links to fix and some reporting metadata to fix too. See the inline comments for more details.

common/alert/index.json-ld Outdated Show resolved Hide resolved
common/alert/reports/a11y-1.json Outdated Show resolved Hide resolved
common/alert/reports/a11y-1.json Outdated Show resolved Hide resolved
common/alert/reports/a11y-1.json Outdated Show resolved Hide resolved
common/alert/reports/a11y-1.json Outdated Show resolved Hide resolved
common/alert/reports/a11y-1.json Outdated Show resolved Hide resolved
@shiva-sc shiva-sc temporarily deployed to github-ci August 24, 2023 21:03 — with GitHub Actions Inactive
@duboisp duboisp added the Query: Project item Part of a github project label Sep 21, 2023
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested locally, everything look good.

Great work on this @shiva-sc

@duboisp duboisp merged commit 01f0f18 into wet-boew:master Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Query: Project item Part of a github project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants