feat: complete notice module #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchwarzSail
requested review from
mutezebra,
ozline,
jiuxia211 and
a team
as code owners
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #154 +/- ##
========================================
- Coverage 3.25% 3.16% -0.10%
========================================
Files 192 200 +8
Lines 40016 41205 +1189
========================================
+ Hits 1303 1304 +1
- Misses 38646 39834 +1188
Partials 67 67
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
分配 @jiuxia211 Review |
jiuxia211
reviewed
Jan 13, 2025
internal/common/pack/notice.go
Outdated
| db "github.com/west2-online/fzuhelper-server/pkg/db/model" | ||
| ) | ||
|
|
||
| func BuildNoticeList(notices *[]db.Notice) []*model.NoticeInfo { |
There was a problem hiding this comment.
为啥是*[]db.Notice 而不是 []*db.Notice
There was a problem hiding this comment.
我之前都是习惯用 []* 的，咱项目也基本都这么用，你这么一问我发现我也不是很清楚原因
There was a problem hiding this comment.
因为本身就是引用类型，自带指向底层数组的指针，我认为像我们项目这样将数据层层传递再包装，不涉及切片的扩容，用*[]需要多解引用一次，肯定是浪费
jiuxia211
reviewed
Jan 13, 2025
jiuxia211
reviewed
Jan 13, 2025
jiuxia211
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
自查 PR 结构
PR 标题符合这个格式: <type>(optional scope): <description>
此 PR 标题的描述以用户为导向，足够清晰，其他人可以理解。
我已经对所有 commit 提供了签名（GPG 密钥签名、SSH 密钥签名）
这个 PR 属于强制变更/破坏性更改
这个 PR 的类型是什么？
这个 PR 做了什么 / 我们为什么需要这个 PR？
(可选)这个 PR 解决了哪个/些 issue？
according to #149
对 Reviewer 预留的一些提醒