Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add concurrency config on deploy.yaml #151

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

ozline
Copy link
Member

@ozline ozline commented Jan 5, 2025

自查 PR 结构

  • PR 标题符合这个格式: <type>(optional scope): <description>

  • 此 PR 标题的描述以用户为导向,足够清晰,其他人可以理解。

  • 我已经对所有 commit 提供了签名(GPG 密钥签名、SSH 密钥签名)

  • 这个 PR 属于强制变更/破坏性更改

如果是,请在 PR 标题中添加 BREAKING CHANGE 前缀,并在 PR 描述中详细说明。

这个 PR 的类型是什么?

feat

这个 PR 做了什么 / 我们为什么需要这个 PR?

当前的 deploy.yaml 并不支持并发运行。例如,当你想同时更新 api 和 academic 服务时,如果你在短时间内同时执行这两个,服务端会产生问题

添加 concurrency 配置以使得相同时间内只有一个 deploy workflow 在运行,其余的 pending

(可选)这个 PR 解决了哪个/些 issue?

对 Reviewer 预留的一些提醒

@ozline ozline requested a review from SchwarzSail as a code owner January 5, 2025 17:16
@ozline ozline enabled auto-merge (squash) January 5, 2025 17:16
@ozline ozline disabled auto-merge January 5, 2025 17:16
SchwarzSail
SchwarzSail previously approved these changes Jan 5, 2025
Copy link
Member

@SchwarzSail SchwarzSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: ozlinex <[email protected]>
@ozline ozline merged commit 617884d into main Jan 5, 2025
6 of 7 checks passed
@ozline ozline deleted the feat/add-concurrency-config branch January 5, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants