fixing model with namespace #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 17, 2017
| if source.is_a?(Array) && source.first.is_a?(String) | ||
| source.map { |v| { value: v, text: v } } | ||
| source.inject({}){|hash, key| hash.merge(key => key)} |
There was a problem hiding this comment.
Space missing to the left of {.
Space between { and | missing.
Space missing inside }.
| @@ -152,9 +135,11 @@ def format_source(source, value) | |||
| if source.is_a?(Array) && source.first.is_a?(String) && source.size == 2 | |||
| { '1' => source[0], '0' => source[1] } | |||
| end | |||
| else | |||
| when String | |||
| else | ||
| safe_join(source_values_for(value, source), tag(:br)) | ||
| end | ||
| safe_join(source_values_for(value, source), tag(:br)) unless %w(select checklist).include? data[:type] |
| @@ -37,7 +37,7 @@ def editable(object, method, options = {}) | |||
| nid = options.delete(:nid) | |||
| nested = options.delete(:nested) | |||
| title = options.delete(:title) do | |||
| klass = nested ? object.class.const_get(nested.to_s.classify) : object.class | |||
| klass = nested ? object.class.const_get(nested.to_s.singularize.capitalize) : object.class | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 40 it resolve the problem with namespace in the model with strong_params on controller.
proposal = Admin::Proposal.first
editable proposal
params on Controller will get "params[:proposal]" and not "params[:admin_proposal]"
I didn't get to compare version 1.5.5 correctty with master