Support no provided source

werein · Apr 8, 2016 · 513cf3e · 513cf3e
1 parent d7766da
commit 513cf3e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/lib/x-editable-rails/view_helpers.rb b/lib/x-editable-rails/view_helpers.rb
@@ -88,6 +88,7 @@ def editable(object, method, options = {})
         private
 
         def normalize_source(source)
+          return [] unless source
           source.map do |el|
             if el.is_a? Array
               el

diff --git a/test/view_helpers_test.rb b/test/view_helpers_test.rb
@@ -87,6 +87,10 @@ def initialize(attributes={})
                  editable(subject_1, :content, type: "select", source: [{ text: "Foo", value: "foo" }, { text: "Bar", value: "bar" }]),
                  "ViewHelpers#editable should generate content tag with the current value"
 
+    refute_match %r{data-source=},
+                 editable(subject_1, :content, type: "select"),
+                 "ViewHelpers#editable should generate content tag without source"
+
     subject_2 = Subject.new(active: true)
 
     assert_match %r{<span[^>]+>Yes</span>},