Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved message readability when renaming a file. #570

Closed
wants to merge 4 commits into from
Closed

Improved message readability when renaming a file. #570

wants to merge 4 commits into from

Conversation

JrmLg
Copy link
Contributor

@JrmLg JrmLg commented Sep 7, 2023

This pull request is related to : #569

I removed the duplicated display of the filename to be renamed.

I also added additional logic when the rename file is in the current directory, the display is even clearer since it only displays the directories of the current project.

@weirongxu
Copy link
Owner

If you want to enable syntax checking on the local environment, you need to install coc-tsserver and coc-eslint, then run yarn install in the project root directory.

@weirongxu
Copy link
Owner

Otherwise, you'd better wait for me to help you modify it later.

@JrmLg
Copy link
Contributor Author

JrmLg commented Sep 9, 2023

Ok, I just resumed the commit by installing the project locally with yarn, it should be good, sorry again.

@weirongxu
Copy link
Owner

I think renameInCwd support should be done by adding a parameter to the rename action, so I remove it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants