Allow writing of entry when full uncompressed size is not known. #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if there is anything I can change to make this acceptable. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some situations require streaming compression where the full size of the input/uncompressed data is not known, such as serializing a large number of objects where loading all the objects into memory would be prohibitive.
Changes proposed in this PR
I assume the progress feedback functionality will not work when passing nil for uncompressedSize. This is ok in my particular use case. I don't think reporting progress is possible when the full size of the data to be compressed is not known.
Thanks for the simple library! Allows us to move off of the aging (and full of warnings/deprecations) minizip library.