Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ingress.yaml #1570

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update ingress.yaml #1570

wants to merge 1 commit into from

Conversation

skjaro
Copy link

@skjaro skjaro commented Mar 4, 2024

Update ingress class for ACME http01 solver for k3s deploy

Update ingress class for ACME http01 solver for k3s deploy
@skjaro
Copy link
Author

skjaro commented Mar 9, 2024

I have issue with deploying certificate for deployment in k3s variant of browsertrix-cloud.
It is related to issue cert-manager/cert-manager#6184

@ikreymer
Copy link
Member

I have issue with deploying certificate for deployment in k3s variant of browsertrix-cloud. It is related to issue cert-manager/cert-manager#6184

Thanks for the PR! I wonder if removing this may break deployment in some cases - perhaps we should make it chart value, eg:

ingress:
  includeClassAnno: false

and if includeClassAnno is set to true it will be included, but can default to false.

Would you might making this change in the PR?

@skjaro
Copy link
Author

skjaro commented Mar 13, 2024

Ok, I try to test it my deployment and then I will fix it...

@vnznznz
Copy link
Contributor

vnznznz commented Mar 24, 2024

I think a better solution might be to allow users to bring their own cert and just provide the name of the secret like here https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus/values.yaml#L364-L370 or here https://github.com/grafana/loki/blob/main/production/helm/loki/values.yaml#L1278-L1282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants