Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to change display name and email #1265

Merged
merged 10 commits into from
Oct 11, 2023

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Oct 10, 2023

Resolves #522

Changes

  • Refreshes account settings page styles
  • Users can change their display name
  • Users can change their email address, with verification status shown (note: backend does not automatically send new verification email)

Manual testing

  1. Log in and click app bar user dropdown -> Account Settings
  2. Enter in a new display name and click "Save". Verify name saves as expected
  3. Enter in a new email address and click "Save". Verify email saves as expected and verification status is updated
  4. Click "Change Password". Verify password input receives focus
  5. Enter in an incorrect current password. Verify form resets and does fails to save
  6. Enter in correct current password and new password. Verify password saves as expected and form is hidden again.

Screenshots

Page Image/video
Account Settings Screenshot 2023-10-10 at 4 32 13 PM
Account Settings - Email (unverified) Screenshot 2023-10-10 at 4 39 18 PM
Account Settings - Password (expanded) Screenshot 2023-10-10 at 4 32 21 PM

Follow-ups

Strong password requirements are not enforced, will be handled in #1233

@Shrinks99
Copy link
Member

Shrinks99 commented Oct 11, 2023

Getting a runtime error on name change.

TypeError: _shoelace_style_shoelace_dist_utilities_form_js__WEBPACK_IMPORTED_MODULE_4__.serialize(...).name is undefined

Email change works! Password change works! 🙌

Shrinks99 added a commit that referenced this pull request Oct 11, 2023
- Preemptive change for #1265
@Shrinks99
Copy link
Member

Removed note about not being able to change names from the docs in e42e040

@SuaYoo
Copy link
Member Author

SuaYoo commented Oct 11, 2023

Getting a runtime error on name change.

Woops! Forgot to push some local changes. Should work now.

Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name updated! 🎉

It doesn't seem to update the name in the workflow config list or within archived items... But that seems like a separate issue.
Screenshot 2023-10-11 at 4 04 49 PM

@SuaYoo
Copy link
Member Author

SuaYoo commented Oct 11, 2023

It doesn't seem to update the name in the workflow config list or within archived items... But that seems like a separate issue.

Yeah, looks like these values returned by the API are not updated:

createdByName
modifiedByName
lastStartedByName

Going to merge this in in order to rebase #1266 and #1272, @tw4l and @ikreymer feel free to leave comments on the merged review and I'll incorporate into the follow-up PRs

@SuaYoo SuaYoo merged commit f1dcc7e into main Oct 11, 2023
2 checks passed
@SuaYoo SuaYoo deleted the frontend-change-user-email-name branch October 11, 2023 20:42
ikreymer pushed a commit that referenced this pull request Oct 17, 2023
Closes #1215

- Adds account settings page
- Adds overview page
- Adds archived items page
- Adds note about browser profile metadata editing
- Adds note on editing the crawler instances scale while crawling
- Adds details on permission levels for the org settings
- Removes note about not being able to change your display name (follows
#1265)
tw4l pushed a commit that referenced this pull request Oct 18, 2023
Closes #1215

- Adds account settings page
- Adds overview page
- Adds archived items page
- Adds note about browser profile metadata editing
- Adds note on editing the crawler instances scale while crawling
- Adds details on permission levels for the org settings
- Removes note about not being able to change your display name (follows
#1265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to change their email & name
2 participants