Add observeAttributes parameter to waitForChildAdd() #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
You must now specify whether waitForChildAdd() should check the predicate on attribute changes. None of its callers depended on this behavior, so the callback and predicate were running hundreds of times unnecessarily. A new parameter, observeAttributes, has been added before abortSignal. When it is true, you will get the old behavior. When it is false, the predicate will not be called on attribute changes.
throwaway96
force-pushed
the
wfca-no-attrs-20240329
branch
from
6f38433 to
a1e4274
Compare
throwaway96
added a commit
that referenced
this pull request
Mar 30, 2024
fire332
pushed a commit
to fire332/youtube-webos
that referenced
this pull request
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You must now specify whether
waitForChildAdd()should check the predicate on attribute changes. Its only caller did not depend on this behavior, so the callback and predicate were running hundreds of times unnecessarily.A new parameter,
observeAttributes, has been added (beforeabortSignal). When it is true, you will get the old behavior. When it is false, the predicate will not be called on attribute changes—meaning you will only see each node once as it is initially added.I don't expect this to have much effect right now, as
waitForChildAdd()is only used once. (It was also used in a now-canceled change.) However, this function is useful enough that it it is likely to be used in the future, including in more performance-sensitive areas.