Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement The Legends and Laurels: Trophies & Triumphs (Part 1) #3657

Merged
merged 9 commits into from
Oct 30, 2024

Conversation

jonasdeluna
Copy link
Member

@jonasdeluna jonasdeluna commented Oct 14, 2024

Description and name (and image) for the trophies were moved to the front-end.
See utils/achievementConstants.ts.

An achievement is uniquely identified using an identifier and a level.

Closing: #3656
Resolves: ABA-1125

@jonasdeluna jonasdeluna self-assigned this Oct 14, 2024
Copy link

linear bot commented Oct 14, 2024

@jonasdeluna jonasdeluna force-pushed the feat-legends-and-laurels branch 7 times, most recently from 95f49ee to 9310de3 Compare October 17, 2024 20:00
@jonasdeluna jonasdeluna force-pushed the feat-legends-and-laurels branch 5 times, most recently from afc2e0f to eb29ef0 Compare October 17, 2024 21:41
@jonasdeluna jonasdeluna changed the title WIP Implement the legends and laurels update Implement the legends and laurels update part 1 Oct 17, 2024
@jonasdeluna jonasdeluna marked this pull request as ready for review October 17, 2024 21:41
@jonasdeluna jonasdeluna force-pushed the feat-legends-and-laurels branch 2 times, most recently from 3f3b42a to c1edcf4 Compare October 17, 2024 21:48
Copy link

@ShaileshS1702 ShaileshS1702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read over once. may look deeply later

lego/apps/achievements/constants.py Outdated Show resolved Hide resolved
@jonasdeluna jonasdeluna force-pushed the feat-legends-and-laurels branch 5 times, most recently from ea816df to 37ce35b Compare October 18, 2024 10:53
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 99.32584% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.51%. Comparing base (f732bae) to head (f587198).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
lego/apps/achievements/promotion.py 95.31% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3657      +/-   ##
==========================================
+ Coverage   89.28%   89.51%   +0.23%     
==========================================
  Files         687      695       +8     
  Lines       21674    22116     +442     
==========================================
+ Hits        19352    19798     +446     
+ Misses       2322     2318       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasdeluna jonasdeluna changed the title Implement The Legends and Laurels: The Path of Glory (Part 1) Implement The Legends and Laurels: Trophies & Triumphs (Part 1) Oct 23, 2024
@jonasdeluna
Copy link
Member Author

jonasdeluna commented Oct 24, 2024

@eikhr Can this be merged? It's done with no errors 👍

lego/apps/achievements/constants.py Outdated Show resolved Hide resolved
lego/apps/achievements/verification.py Outdated Show resolved Hide resolved
lego/apps/achievements/verification.py Outdated Show resolved Hide resolved
lego/apps/achievements/verification.py Outdated Show resolved Hide resolved
lego/apps/events/views.py Outdated Show resolved Hide resolved
lego/apps/achievements/promotion.py Outdated Show resolved Hide resolved
lego/apps/achievements/tasks.py Outdated Show resolved Hide resolved
lego/apps/achievements/tests/tests.py Outdated Show resolved Hide resolved
@jonasdeluna jonasdeluna force-pushed the feat-legends-and-laurels branch 6 times, most recently from 2a86675 to 51c2577 Compare October 30, 2024 19:38
Copy link
Member

@eikhr eikhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Just add the two tests we talked about, event registering throught api and removal of top event participant achievement.

🏆 :shipit:

@jonasdeluna jonasdeluna merged commit d6adae0 into master Oct 30, 2024
1 check passed
@jonasdeluna jonasdeluna deleted the feat-legends-and-laurels branch October 30, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants