-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement The Legends and Laurels: Trophies & Triumphs (Part 1) #3657
Conversation
95f49ee
to
9310de3
Compare
afc2e0f
to
eb29ef0
Compare
3f3b42a
to
c1edcf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
read over once. may look deeply later
ea816df
to
37ce35b
Compare
931f693
to
a1618c5
Compare
a1618c5
to
3522de9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3657 +/- ##
==========================================
+ Coverage 89.28% 89.51% +0.23%
==========================================
Files 687 695 +8
Lines 21674 22116 +442
==========================================
+ Hits 19352 19798 +446
+ Misses 2322 2318 -4 ☔ View full report in Codecov by Sentry. |
@eikhr Can this be merged? It's done with no errors 👍 |
2a86675
to
51c2577
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Just add the two tests we talked about, event registering throught api and removal of top event participant achievement.
🏆
51c2577
to
2d987b2
Compare
2d987b2
to
f587198
Compare
Description and name (and image) for the trophies were moved to the front-end.
See utils/achievementConstants.ts.
An achievement is uniquely identified using an identifier and a level.
Closing: #3656
Resolves: ABA-1125