-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple canvas sample. #389
Conversation
Note: AFAICT the stanford dragon was getting flat shading. If that was the intent I can remove the genarateNormals code but I assumed the intent was smooth shading. I do kind of wonder if we should just genearte then once and put them in the data file 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New sample looks great!
meshes/utils.ts
Outdated
// this assumes vertex positions are an exact match | ||
|
||
function getVertIndex(vert: [number, number, number]): number { | ||
const vertId = `${vert[0]},${vert[1]},${vert[2]}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This vertId doesn't look super ... cool? but I'm good with everything that just works :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to JSON.stringify(vert)
which works.
No I don't think flat shading is specially intended.
I'm good with either way. In that case less effort is prferred, so we can just keep things as-is :) |
There is #302 about artifacts in the dragon model because I think we are using the original 3d scanned model file instead of a cleaned-up version. If we replace it then we can add normals and stuff. |
Note: AFAICT the stanford dragon was getting flat shading. If that was the intent I can remove the genarateNormals code but I assumed the intent was smooth shading.
I do kind of wonder if we should just genearte then once and put them in the data file 😛