Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

Updates fibers to 3.0 to support node >=10 #132

Closed
wants to merge 5 commits into from
Closed

Updates fibers to 3.0 to support node >=10 #132

wants to merge 5 commits into from

Conversation

BorisOsipov
Copy link
Contributor

Updates fibers to 3.0 to support node >=10

Fixed webdriverio-boneyard/wdio-cucumber-framework#153

@christian-bromann
Copy link
Contributor

Something with the Babel compiling went wrong:

/home/travis/build/webdriverio-boneyard/wdio-sync/test/addCommand.spec.js:3
import _Object$keys from 'babel-runtime/core-js/object/keys';
^^^^^^
SyntaxError: Unexpected token import

@BorisOsipov
Copy link
Contributor Author

Yep, it doesn't work at master for me. Will fix.

christian-bromann
christian-bromann suggested changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

.babelrc
"add-module-exports",
{
"plugins": [
"rewire",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's only use this plugin in testing environment

.babelrc
@@ -1,15 +1,24 @@
{
"passPerPreset": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we need this option, happy to bump up the node target to 8

@BorisOsipov
Copy link
Contributor Author

Сan not fix it. Current package.json with updated fibers produce a real mess of babel 6 and 7.beta dependencies. Don't have time to deal with it.

@christian-bromann christian-bromann deleted the update_fibers branch October 25, 2018 11:51
@christian-bromann christian-bromann mentioned this pull request Oct 26, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christian-bromann christian-bromann christian-bromann requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BorisOsipov @christian-bromann