Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

Wrap debug command to ensure mocha timeout not triggered #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaridmargolin
Copy link

This is not the final implementation (missing tests), but wanted to open a quick PR to discuss if this would conceptually be considered for merge.

@jsf-clabot
Copy link

jsf-clabot commented Dec 13, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@jaridmargolin
Copy link
Author

@christian-bromann any chance you could give this a quick look? This fixes the very annoying issue of needing to set the timeout each time you need to use a debug statement.

@christian-bromann
Copy link
Contributor

Hey, yeah this would be very helpful. We should be consistent with Jasmine and Cucumber and apply the same change there too.

@jaridmargolin
Copy link
Author

Ok... I have a little less familiarity with these two runners, but I'll give it a look.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants