Fixes #74. Build web extension compatible addons from shared modules. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 1, 2018 21:48
No need to lint or care about changes to built files.
|
Will it partially help with #70 |
I don't think so. This PR is just about DRY, currently there's 3 (nearly) identical web-extension background.js files for Chrome, Firefox, Opera. |
|
Ugh. This history is borked. I'm going to close this PR and open a new one after cherry picking my commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meh, some extra commits in here because I started hacking on an old branch. Shrugs.
Anyways, WIP. Need to convert over Chrome and Opera addons, then write some code to build 'em and move 'em to the bin directory.
(not ready for review)